Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AssertJ as() and describedAs() in AssertionHandler #885

Merged
merged 6 commits into from
Dec 26, 2023

Conversation

msridhar
Copy link
Collaborator

Fixes #877

Copy link

codecov bot commented Dec 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ce41599) 87.09% compared to head (d9ec5f3) 87.18%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #885      +/-   ##
============================================
+ Coverage     87.09%   87.18%   +0.09%     
- Complexity     1940     1950      +10     
============================================
  Files            77       77              
  Lines          6267     6274       +7     
  Branches       1218     1219       +1     
============================================
+ Hits           5458     5470      +12     
  Misses          405      405              
+ Partials        404      399       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@yuxincs yuxincs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR LGTM, I only have a few questions/nits :)

@msridhar msridhar enabled auto-merge (squash) December 26, 2023 19:20
@msridhar msridhar merged commit c44ab8d into master Dec 26, 2023
10 checks passed
@msridhar msridhar deleted the issue-877 branch December 26, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

assertThat(...).as(...).isNotNull() is not recognized
2 participants