Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Error Prone 2.24.1 #888

Merged
merged 3 commits into from
Jan 3, 2024
Merged

Update to Error Prone 2.24.1 #888

merged 3 commits into from
Jan 3, 2024

Conversation

msridhar
Copy link
Collaborator

@msridhar msridhar commented Jan 3, 2024

Just to stay up to date.

A repo owner will have to update the required CI jobs before this can land.

@msridhar msridhar requested a review from yuxincs January 3, 2024 15:48
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b5cd1f9) 87.20% compared to head (07bcc51) 87.20%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #888   +/-   ##
=========================================
  Coverage     87.20%   87.20%           
  Complexity     1947     1947           
=========================================
  Files            77       77           
  Lines          6268     6268           
  Branches       1216     1216           
=========================================
  Hits           5466     5466           
  Misses          403      403           
  Partials        399      399           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@yuxincs yuxincs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EP Upgrade LGTM!

A repo owner will have to update the required CI jobs before this can land.

Ruleset updated :) this means other pending PRs may have to be rebased in order to be merged after this.

@msridhar msridhar changed the title Update to Error Prone 2.24.0 Update to Error Prone 2.24.1 Jan 3, 2024
@msridhar
Copy link
Collaborator Author

msridhar commented Jan 3, 2024

Sorry @yuxincs EP 2.24.1 was just released this morning after I opened this PR, so I changed this PR to just update to that version. Unfortunately the required CI job names will need to be updated again.

@yuxincs
Copy link
Collaborator

yuxincs commented Jan 3, 2024

Ruleset updated for 2.24.1 👍

@msridhar msridhar enabled auto-merge (squash) January 3, 2024 19:10
@msridhar msridhar merged commit 257e4bb into uber:master Jan 3, 2024
10 checks passed
@msridhar msridhar deleted the ep-2.24.0 branch January 3, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants