Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External Library Models: Adding support for Nullable upper bounds of Generic Type parameters #949

Merged
merged 21 commits into from
Jun 7, 2024

Merge branch 'master' into library_model_nullable_upper_bound

d679ed0
Select commit
Loading
Failed to load commit list.
Merged

External Library Models: Adding support for Nullable upper bounds of Generic Type parameters #949

Merge branch 'master' into library_model_nullable_upper_bound
d679ed0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Jun 4, 2024 in 0s

66.66% of diff hit (target 86.17%)

View this Pull Request on Codecov

66.66% of diff hit (target 86.17%)

Annotations

Check warning on line 75 in library-model/library-model-generator/src/main/java/com/uber/nullaway/libmodel/LibraryModelGenerator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

library-model/library-model-generator/src/main/java/com/uber/nullaway/libmodel/LibraryModelGenerator.java#L73-L75 

Added lines #L73 - L75 were not covered by tests

Check warning on line 93 in library-model/library-model-generator/src/main/java/com/uber/nullaway/libmodel/LibraryModelGenerator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

library-model/library-model-generator/src/main/java/com/uber/nullaway/libmodel/LibraryModelGenerator.java#L93 

Added line #L93 was not covered by tests

Check warning on line 146 in library-model/library-model-generator/src/main/java/com/uber/nullaway/libmodel/LibraryModelGenerator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

library-model/library-model-generator/src/main/java/com/uber/nullaway/libmodel/LibraryModelGenerator.java#L145-L146 

Added lines #L145 - L146 were not covered by tests

Check warning on line 176 in library-model/library-model-generator/src/main/java/com/uber/nullaway/libmodel/LibraryModelGenerator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

library-model/library-model-generator/src/main/java/com/uber/nullaway/libmodel/LibraryModelGenerator.java#L176 

Added line #L176 was not covered by tests

Check warning on line 178 in library-model/library-model-generator/src/main/java/com/uber/nullaway/libmodel/LibraryModelGenerator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

library-model/library-model-generator/src/main/java/com/uber/nullaway/libmodel/LibraryModelGenerator.java#L178 

Added line #L178 was not covered by tests

Check warning on line 211 in library-model/library-model-generator/src/main/java/com/uber/nullaway/libmodel/LibraryModelGenerator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

library-model/library-model-generator/src/main/java/com/uber/nullaway/libmodel/LibraryModelGenerator.java#L211 

Added line #L211 was not covered by tests

Check warning on line 213 in library-model/library-model-generator/src/main/java/com/uber/nullaway/libmodel/LibraryModelGenerator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

library-model/library-model-generator/src/main/java/com/uber/nullaway/libmodel/LibraryModelGenerator.java#L213 

Added line #L213 was not covered by tests

Check warning on line 291 in library-model/library-model-generator/src/main/java/com/uber/nullaway/libmodel/LibraryModelGenerator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

library-model/library-model-generator/src/main/java/com/uber/nullaway/libmodel/LibraryModelGenerator.java#L290-L291 

Added lines #L290 - L291 were not covered by tests

Check warning on line 293 in library-model/library-model-generator/src/main/java/com/uber/nullaway/libmodel/LibraryModelGenerator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

library-model/library-model-generator/src/main/java/com/uber/nullaway/libmodel/LibraryModelGenerator.java#L293 

Added line #L293 was not covered by tests

Check warning on line 296 in library-model/library-model-generator/src/main/java/com/uber/nullaway/libmodel/LibraryModelGenerator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

library-model/library-model-generator/src/main/java/com/uber/nullaway/libmodel/LibraryModelGenerator.java#L296 

Added line #L296 was not covered by tests

Check warning on line 298 in library-model/library-model-generator/src/main/java/com/uber/nullaway/libmodel/LibraryModelGenerator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

library-model/library-model-generator/src/main/java/com/uber/nullaway/libmodel/LibraryModelGenerator.java#L298 

Added line #L298 was not covered by tests

Check warning on line 300 in library-model/library-model-generator/src/main/java/com/uber/nullaway/libmodel/LibraryModelGenerator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

library-model/library-model-generator/src/main/java/com/uber/nullaway/libmodel/LibraryModelGenerator.java#L300 

Added line #L300 was not covered by tests

Check warning on line 128 in library-model/library-model-generator/src/main/java/com/uber/nullaway/libmodel/StubxWriter.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

library-model/library-model-generator/src/main/java/com/uber/nullaway/libmodel/StubxWriter.java#L127-L128 

Added lines #L127 - L128 were not covered by tests

Check warning on line 134 in library-model/library-model-generator/src/main/java/com/uber/nullaway/libmodel/StubxWriter.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

library-model/library-model-generator/src/main/java/com/uber/nullaway/libmodel/StubxWriter.java#L131-L134 

Added lines #L131 - L134 were not covered by tests

Check warning on line 80 in nullaway/src/main/java/com/uber/nullaway/handlers/InferredJARModelsHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

nullaway/src/main/java/com/uber/nullaway/handlers/InferredJARModelsHandler.java#L80 

Added line #L80 was not covered by tests

Check warning on line 52 in nullaway/src/main/java/com/uber/nullaway/handlers/StubxCacheUtil.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

nullaway/src/main/java/com/uber/nullaway/handlers/StubxCacheUtil.java#L52 

Added line #L52 was not covered by tests

Check warning on line 101 in nullaway/src/main/java/com/uber/nullaway/handlers/StubxCacheUtil.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

nullaway/src/main/java/com/uber/nullaway/handlers/StubxCacheUtil.java#L100-L101 

Added lines #L100 - L101 were not covered by tests

Check warning on line 113 in nullaway/src/main/java/com/uber/nullaway/handlers/StubxCacheUtil.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

nullaway/src/main/java/com/uber/nullaway/handlers/StubxCacheUtil.java#L113 

Added line #L113 was not covered by tests

Check warning on line 129 in nullaway/src/main/java/com/uber/nullaway/handlers/StubxCacheUtil.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

nullaway/src/main/java/com/uber/nullaway/handlers/StubxCacheUtil.java#L128-L129 

Added lines #L128 - L129 were not covered by tests

Check warning on line 137 in nullaway/src/main/java/com/uber/nullaway/handlers/StubxCacheUtil.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

nullaway/src/main/java/com/uber/nullaway/handlers/StubxCacheUtil.java#L136-L137 

Added lines #L136 - L137 were not covered by tests

Check warning on line 154 in nullaway/src/main/java/com/uber/nullaway/handlers/StubxCacheUtil.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

nullaway/src/main/java/com/uber/nullaway/handlers/StubxCacheUtil.java#L154 

Added line #L154 was not covered by tests
View more details on Codecov