-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat : Cells to multipolygon #64
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1448d72
feat: add support for cells to multipolygon and tests
SoulPancake 38728a2
feat: remove TODO comments
SoulPancake 2478e34
fix: test case
SoulPancake 827b53e
feat: fix test
SoulPancake 27f1d3d
fix: test case tolerance for float precision
SoulPancake File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -98,8 +98,10 @@ type ( | |
} | ||
|
||
// LinkedGeoPolygon is a linked-list of GeoPolygons. | ||
// TODO: not implemented. | ||
LinkedGeoPolygon struct{} | ||
LinkedGeoPolygon struct { | ||
Data GeoPolygon | ||
Next *LinkedGeoPolygon | ||
} | ||
) | ||
|
||
func NewLatLng(lat, lng float64) LatLng { | ||
|
@@ -246,8 +248,33 @@ func (p GeoPolygon) Cells(resolution int) []Cell { | |
return PolygonToCells(p, resolution) | ||
} | ||
|
||
func CellToGeoPolygon(cell Cell) GeoPolygon { | ||
boundary := CellToBoundary(cell) | ||
loop := make(GeoLoop, len(boundary)) | ||
|
||
for i, coord := range boundary { | ||
loop[i] = LatLng{Lat: coord.Lat, Lng: coord.Lng} | ||
} | ||
|
||
return GeoPolygon{GeoLoop: loop} | ||
} | ||
|
||
func CellsToMultiPolygon(cells []Cell) *LinkedGeoPolygon { | ||
panic("not implemented") | ||
var head, current *LinkedGeoPolygon | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd expect this function to wrap |
||
|
||
for _, cell := range cells { | ||
geoPoly := CellToGeoPolygon(cell) | ||
|
||
if head == nil { | ||
head = &LinkedGeoPolygon{Data: geoPoly} | ||
current = head | ||
} else { | ||
current.Next = &LinkedGeoPolygon{Data: geoPoly} | ||
current = current.Next | ||
} | ||
} | ||
|
||
return head | ||
} | ||
|
||
// PointDistRads returns the "great circle" or "haversine" distance between | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In uber/h3, this seems to be doubly-linked: https://github.com/uber/h3/blob/138a7487adb0892715ea7ced785db4e9c38842d1/src/h3lib/include/h3api.h.in#L179
Does that need to be maintained here?