Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop 2.7 tests and avoid Cython warning #324

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Drop 2.7 tests and avoid Cython warning #324

merged 2 commits into from
Aug 11, 2023

Conversation

ajfriend
Copy link
Contributor

@ajfriend ajfriend commented Aug 11, 2023

Set language level to avoid:

[1/1] Cythonizing /Users/ajfriend/work/h3-py/tests/cython_example.pyx
/Users/ajfriend/work/h3-py/env/lib/python3.11/site-packages/Cython/Compiler/Main.py:381: FutureWarning: Cython directive 'language_level' not set, using '3str' for now (Py3). This has changed from earlier releases! File: /Users/ajfriend/work/h3-py/tests/cython_example.pyx

Also, drop Python 2.7 from test matrix.

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ae9865c) 100.00% compared to head (45d1df0) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #324   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines          389       389           
=========================================
  Hits           389       389           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ajfriend ajfriend changed the title Avoid cython warning Drop 2.7 tests and avoid Cython warning Aug 11, 2023
@isaacbrodsky isaacbrodsky merged commit f3f0144 into master Aug 11, 2023
17 checks passed
@isaacbrodsky isaacbrodsky deleted the aj_update branch August 11, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants