Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hierarchy.mdx: Fix call to nonexistent compact in js example for uncompactCells #812

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

ericbf
Copy link
Contributor

@ericbf ericbf commented Jan 17, 2024

The uncompactCells example for js makes a call to compact, which no longer exists. It should use compactCells.

The `uncompactCells` example for `js` makes a call to `compact`, which no longer exists. It should use `compactCells`.
@CLAassistant
Copy link

CLAassistant commented Jan 17, 2024

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

coverage: 98.824%. remained the same
when pulling d65d0e5 on ericbf:patch-1
into 48c047c on uber:master.

@nrabinowitz
Copy link
Collaborator

Thanks for the fix!

@nrabinowitz nrabinowitz merged commit 138a748 into uber:master Jan 17, 2024
34 checks passed
@ericbf ericbf deleted the patch-1 branch January 17, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants