Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creation of Configuration Component #19

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

GerritBurgerDev
Copy link
Collaborator

@GerritBurgerDev GerritBurgerDev commented Jan 27, 2022

image

@@ -0,0 +1,11 @@
.mat-slide-toggle.mat-checked {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't quite know where to add this global overwrite so I made a new file for it? Should we rather have a material.scss file for all global angular material overwrites? @ubergeoff

<ng-container *ngIf="!!configComponent">
<div
class="config-sliders"
rooiComponentConfig
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allows for each example/component to have it's own configuration component

styleUrls: ['./component-configuration.component.scss']
})
export class ComponentConfigurationComponent {
@Input() title: string | undefined;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for some reason ESLint wants these | undefined types. I don't like it though, should I update the eslint rules?

@@ -0,0 +1,36 @@
<div class="config-container">
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the most detailed example, but Angular Material's updating is sub-par tbh

constructor(private matTableDemoService: MatTableDemoService) {}

toggleRowExpansion(): void {
this.componentConfiguration.enableRowExpansion = !this.componentConfiguration.enableRowExpansion;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be updated. Angular Material table needs a force update to make this work. Do you know how to externally force an update?

this.rowComponent = MatTableRowDemoComponent;
this.expandedRowComponent = MatTableExpansionRowDemoComponent;
// this.expandedRowComponent = MatTableExpansionRowDemoComponent;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be removed

@ubergeoff
Copy link
Owner

@GerritBurgerDev - Failing build..? Need some help..?

@GerritBurgerDev
Copy link
Collaborator Author

GerritBurgerDev commented Feb 5, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants