Fix incorrect namespace & remove linting overrides (#12)

* Fix incorrect namespace & remove linting overrides * Update changelog
ubient · Feb 1, 2019 · 3d7d7f7 · 3d7d7f7
1 parent 1db6003
commit 3d7d7f7
Show file tree

Hide file tree

Showing 10 changed files with 9 additions and 38 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 All notable changes to `ubient/laravel-flash-message` will be documented in this file
 
+## 2.0.2 - 2019-02-01
+- Fixed an incorrect namespacing issue for multiple files in the `tests/Unit/` folder
+- Removed (opinionated) linter overrides from tests
+
 ## 2.0.1 - 2018-11-04
 - Remove a trailing semicolon in `alert.blade.php`
 

diff --git a/tests/Feature/AssertHasFlashMessage/AssertHasErrorMessageTest.php b/tests/Feature/AssertHasFlashMessage/AssertHasErrorMessageTest.php
@@ -5,10 +5,6 @@
 use Ubient\FlashMessage\Tests\TestCase;
 use PHPUnit\Framework\ExpectationFailedException;
 
-/**
- * @SuppressWarnings(PHPMD.CamelCaseMethodName)
- * phpcs:disable PSR1.Methods.CamelCapsMethodName.NotCamelCaps
- */
 class AssertHasErrorMessageTest extends TestCase
 {
     /** @test */

diff --git a/tests/Feature/AssertHasFlashMessage/AssertHasInfoMessageTest.php b/tests/Feature/AssertHasFlashMessage/AssertHasInfoMessageTest.php
@@ -5,10 +5,6 @@
 use Ubient\FlashMessage\Tests\TestCase;
 use PHPUnit\Framework\ExpectationFailedException;
 
-/**
- * @SuppressWarnings(PHPMD.CamelCaseMethodName)
- * phpcs:disable PSR1.Methods.CamelCapsMethodName.NotCamelCaps
- */
 class AssertHasInfoMessageTest extends TestCase
 {
     /** @test */

diff --git a/tests/Feature/AssertHasFlashMessage/AssertHasSuccessMessageTest.php b/tests/Feature/AssertHasFlashMessage/AssertHasSuccessMessageTest.php
@@ -5,10 +5,6 @@
 use Ubient\FlashMessage\Tests\TestCase;
 use PHPUnit\Framework\ExpectationFailedException;
 
-/**
- * @SuppressWarnings(PHPMD.CamelCaseMethodName)
- * phpcs:disable PSR1.Methods.CamelCapsMethodName.NotCamelCaps
- */
 class AssertHasSuccessMessageTest extends TestCase
 {
     /** @test */

diff --git a/tests/Feature/AssertHasFlashMessage/AssertHasWarningMessageTest.php b/tests/Feature/AssertHasFlashMessage/AssertHasWarningMessageTest.php
@@ -5,10 +5,6 @@
 use Ubient\FlashMessage\Tests\TestCase;
 use PHPUnit\Framework\ExpectationFailedException;
 
-/**
- * @SuppressWarnings(PHPMD.CamelCaseMethodName)
- * phpcs:disable PSR1.Methods.CamelCapsMethodName.NotCamelCaps
- */
 class AssertHasWarningMessageTest extends TestCase
 {
     /** @test */

diff --git a/tests/Feature/FlashMessageServiceProviderTest.php b/tests/Feature/FlashMessageServiceProviderTest.php
@@ -8,10 +8,6 @@
 use Illuminate\Foundation\Testing\TestResponse;
 use Ubient\FlashMessage\FlashMessageServiceProvider;
 
-/**
- * @SuppressWarnings(PHPMD.CamelCaseMethodName)
- * phpcs:disable PSR1.Methods.CamelCapsMethodName.NotCamelCaps
- */
 class FlashMessageServiceProviderTest extends TestCase
 {
     /** @var string */

diff --git a/tests/Feature/RedirectWithFlashMessageTest.php b/tests/Feature/RedirectWithFlashMessageTest.php
@@ -4,10 +4,6 @@
 
 use Ubient\FlashMessage\Tests\TestCase;
 
-/**
- * @SuppressWarnings(PHPMD.CamelCaseMethodName)
- * phpcs:disable PSR1.Methods.CamelCapsMethodName.NotCamelCaps
- */
 class RedirectWithFlashMessageTest extends TestCase
 {
     /** @test */

diff --git a/tests/Feature/ViewFlashMessageTest.php b/tests/Feature/ViewFlashMessageTest.php
@@ -5,15 +5,14 @@
 use Ubient\FlashMessage\Tests\TestCase;
 use PHPUnit\Framework\ExpectationFailedException;
 
-/**
- * @SuppressWarnings(PHPMD.CamelCaseMethodName)
- * phpcs:disable PSR1.Methods.CamelCapsMethodName.NotCamelCaps
- */
 class ViewFlashMessageTest extends TestCase
 {
     const CSS_CLASS_INFO = 'bg-blue-light';
+
     const CSS_CLASS_SUCCESS = 'bg-green-light';
+
     const CSS_CLASS_WARNING = 'bg-orange';
+
     const CSS_CLASS_ERROR = 'bg-red-light';
 
     public function setUp()

diff --git a/tests/Unit/FlashMessageTest.php b/tests/Unit/FlashMessageTest.php
@@ -1,14 +1,10 @@
 <?php
 
-namespace Ubient\FlashMessage\Unit;
+namespace Ubient\FlashMessage\Tests\Unit;
 
 use Ubient\FlashMessage\FlashMessage;
 use Ubient\FlashMessage\Tests\TestCase;
 
-/**
- * @SuppressWarnings(PHPMD.CamelCaseMethodName)
- * phpcs:disable PSR1.Methods.CamelCapsMethodName.NotCamelCaps
- */
 class FlashMessageTest extends TestCase
 {
     /** @test */

diff --git a/tests/Unit/HasFlashMessageConstraintTest.php b/tests/Unit/HasFlashMessageConstraintTest.php
@@ -1,16 +1,12 @@
 <?php
 
-namespace Ubient\FlashMessage\Unit\PHPUnit;
+namespace Ubient\FlashMessage\Tests\Unit;
 
 use PHPUnit\Framework\TestFailure;
 use Ubient\FlashMessage\Tests\TestCase;
 use PHPUnit\Framework\ExpectationFailedException;
 use Ubient\FlashMessage\HasFlashMessageConstraint;
 
-/**
- * @SuppressWarnings(PHPMD.CamelCaseMethodName)
- * phpcs:disable PSR1.Methods.CamelCapsMethodName.NotCamelCaps
- */
 class HasFlashMessageConstraintTest extends TestCase
 {
     protected function assertFailingConstraint($expected, $actual, $expectedErrorMessage)