Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure: Summarise version and features #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rwmjones
Copy link
Contributor

@rwmjones rwmjones commented Feb 7, 2023

In ./configure output summarise the version of ubdsrv and the features which have been enabled.

Signed-off-by: Richard W.M. Jones [email protected]

In ./configure output summarise the version of ubdsrv and the features
which have been enabled.

Signed-off-by: Richard W.M. Jones <[email protected]>
AS_ECHO_N(" gnutls ................. ")
if test "x$HAVE_GNUTLS" = "x1"; then echo "yes"; else echo "no"; fi
AS_ECHO_N(" large file support ..... ")
if test "$NBD_LFS" -eq "1"; then echo "yes"; else echo "no"; fi
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Richard,

The Summary log is very nice, but not sure if it is good to add the two nbd specific features log here.

Thanks,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My intent was to list all optional features (but actually I missed SDP). The reason for showing them is it makes it easy to see if you're building a full-featured package -- is "yes" present on every line.

@rwmjones
Copy link
Contributor Author

rwmjones commented Feb 7, 2023

BTW why does ublk even have an NBD client? We've written one already using the much more featureful libnbd: https://gitlab.com/nbdkit/libnbd/-/tree/master/ublk

@ming1
Copy link
Collaborator

ming1 commented Feb 7, 2023

BTW why does ublk even have an NBD client? We've written one already using the much more featureful libnbd: https://gitlab.com/nbdkit/libnbd/-/tree/master/ublk

Because nbd is very simple network storage and as you see, the implementation is easy(new added code is just tgt_nbd.c, which
just replaces kernel nbd driver).

And ublk-nbd is totally based on io_uring, so we can evaluate ublk/io_uring net handling performance.

Also last time, when I compare nbdublk with nbd-client & nbd
driver, nbdublk performs a bit wore than nbd driver.

Thanks,

@rwmjones
Copy link
Contributor Author

rwmjones commented Feb 7, 2023

I'd like to make a more coherent NBD ecosystem, and one part of that is supporting NBD URIs as much as possible. In libnbd's nbdublk you can do for example:

nbdublk /dev/ublkb0 nbd://server
nbdublk /dev/ublkb0 nbds://server:1234
nbdublk /dev/ublkb0 nbd+unix:///exportname?socket=/tmp/sock

This is one of the advantages of using a single library everywhere (although you could also consider adding URI support to ublk by following the spec).

@ming1
Copy link
Collaborator

ming1 commented Feb 7, 2023

I'd like to make a more coherent NBD ecosystem, and one part of that is supporting NBD URIs as much as possible. In libnbd's nbdublk you can do for example:

nbdublk /dev/ublkb0 nbd://server
nbdublk /dev/ublkb0 nbds://server:1234
nbdublk /dev/ublkb0 nbd+unix:///exportname?socket=/tmp/sock

OK, the URI interface looks one good idea.

This is one of the advantages of using a single library everywhere (although you could also consider adding URI support to ublk by following the spec).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants