Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(steam): Do not preload extest in KDE plasma #1676

Closed
wants to merge 1 commit into from

Conversation

Zeglius
Copy link
Contributor

@Zeglius Zeglius commented Sep 16, 2024

This would fix issue #1675 in KDE images

@KyleGospo KyleGospo marked this pull request as ready for review September 16, 2024 14:40
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 16, 2024
KyleGospo
KyleGospo previously approved these changes Sep 16, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 16, 2024
@dosubot dosubot bot added the bug Something isn't working label Sep 16, 2024
@HikariKnight
Copy link
Member

Wont this break steam input on KDE? like the Desktop Layout and such.

@Zeglius
Copy link
Contributor Author

Zeglius commented Sep 16, 2024

Wont this break steam input on KDE? like the Desktop Layout and such.

Didn't think of that. Thanks for pointing that out.
Probably this should do better in the testing branch.

@Zeglius Zeglius changed the base branch from main to testing September 16, 2024 22:01
@Zeglius Zeglius dismissed KyleGospo’s stale review September 16, 2024 22:01

The base branch was changed.

@HikariKnight
Copy link
Member

im more comfortable with this in testing to test it properly first, will do some testing after work tomorrow to check steam input as i rely on it a lot on desktop

@HikariKnight
Copy link
Member

@Zeglius i have tested this today, seems to not impact steam input just gives a dialog asking for remote input access and once granted seem to not ask again (will check again after reboot) but so far seems good.

@HikariKnight
Copy link
Member

HikariKnight commented Sep 21, 2024

ok so after every reboot (or relogin) the user will have to re-accept the remote control prompt when trying to use steam input with steam chords (like opening the keyboard), this i can imagine is fine on the desktop image not on the -deck image
image

Also when i tested it did not fix the big picture mode lag on my end 🤔

@Zeglius
Copy link
Contributor Author

Zeglius commented Sep 21, 2024

ok so after every reboot (or relogin) the user will have to re-accept the remote control prompt when trying to use steam input with steam chords (like opening the keyboard), this i can imagine is fine on the desktop image not on the -deck image
image

Also when i tested it did not fix the big picture mode lag on my end 🤔

How did you test this? This PR seems didn't get merged in :testing.

@Zeglius
Copy link
Contributor Author

Zeglius commented Sep 21, 2024

Ok so I have been testing a little bit and seems extest is not the cause of the lag.

I could reproduce the lag by launching bazzite-steam in the terminal, but not when launching from the app menu

I checked the difference between both in /proc/PID/environ, from terminal and from app menu, and it seems it was switcheroo all along, which doesnt inject the required env vars when in terminal.

As soon I launched bazzite-steam with switcheroo launch bazzite-steam, the lag was gone

@HikariKnight
Copy link
Member

ok so after every reboot (or relogin) the user will have to re-accept the remote control prompt when trying to use steam input with steam chords (like opening the keyboard), this i can imagine is fine on the desktop image not on the -deck image
image
Also when i tested it did not fix the big picture mode lag on my end 🤔

How did you test this? This PR seems didn't get merged in :testing.

just downloaded the script and tested with that :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants