Skip to content

Commit

Permalink
feat: Stop supporting chsh (#624)
Browse files Browse the repository at this point in the history
  • Loading branch information
@KyleGospo
KyleGospo authored Aug 8, 2024
1 parent f2e0055 commit 1298125
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions Containerfile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ RUN --mount=type=cache,dst=/var/cache/rpm-ostree \
--mount=type=bind,from=config,src=/rpms,dst=/tmp/rpms \
--mount=type=bind,from=akmods,src=/rpms/ublue-os,dst=/tmp/akmods-rpms \
--mount=type=bind,from=kernel,src=/tmp/rpms,dst=/tmp/kernel-rpms \
rm -f /usr/bin/chsh && \
mkdir -p /var/lib/alternatives && \
/ctx/install.sh && \
/ctx/post-install.sh && \
Expand Down

1 comment on commit 1298125

@dperson
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get that you don't think that people should be using chsh and should set an alternate shell in their terminal app. Yes I can and will just edit my /etc/passwd file with sudoedit because I often access my systems via ssh. This is just too far, IMHO.

As an alternative to deleting the tool (generally only people that are going to use it will be able to modify it anyway now that it's not in a just easy access wrapper). I can write a wrapper script to go in /usr/bin/chsh.wrapper and shell aliases for /etc/profile.d that can show your reasoning and a link to the post on how to setup the terminal, before asking to continue. But the chsh command provides some safety checking that you are specifying a real shell (no typos and correct path). IMHO, you're in effect currently making the bad outcomes more likely.

Please sign in to comment.