Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove confusing Notification regarding System updates #128

Merged
merged 1 commit into from
Sep 1, 2024

Conversation

remggo
Copy link
Contributor

@remggo remggo commented Aug 23, 2024

This commit removes the "System passed checks, updating ..." which is confusing as it will trigger every 6 hours even if there is no update available to install.

If there are other opinions on how to solve this, please let me know and I am happy to code something up.
I was just very confused the last days that my system "seemed" to update, but there were no system updates available.
Maybe there could be something done with the wording.

@gerblesh
Copy link
Collaborator

gerblesh commented Aug 26, 2024

I agree that it is annoying to get the notification every 6 hours without fail. There could also be checks in place to only send the notification when an update for the image is found. The idea of the notifications was to have some way of telling the user that updates were running in the background. Appindicator might be one such solution, or something similar maybe?

@remggo
Copy link
Contributor Author

remggo commented Aug 27, 2024

Hey, I have seen that I have broke the tests. I will fix that and try to propose a solution that only Shows the notification if there is a System Upgrade.

The notification is not totally wrong as Flatpak updates and Distrobox Updates (via topgrade) could be considered System Updates. However, I would only show the notification if there is an update of the bluefin/aurora image itself, as that notification would nudge me to wait for the restart notification.

@remggo remggo marked this pull request as draft August 27, 2024 05:08
@remggo remggo force-pushed the fix/remove-confusing-notify branch 2 times, most recently from 4f08c99 to dfae4bf Compare August 27, 2024 18:43
@remggo remggo marked this pull request as ready for review August 27, 2024 18:44
@remggo
Copy link
Contributor Author

remggo commented Aug 27, 2024

I have read the code a little bit more and actually the info if a system update is available gets passed into the function. I have added a test to see that no notifications are being sent if there is no system update.

@remggo remggo force-pushed the fix/remove-confusing-notify branch from 48b2221 to dfae4bf Compare August 27, 2024 18:47
This commit only shows the "System passed checks, updating ..." notification
if a system update is available, not always when the ublue-update system
update is being run.
@remggo remggo force-pushed the fix/remove-confusing-notify branch from dfae4bf to d3123c0 Compare August 27, 2024 18:48
@gerblesh gerblesh added this pull request to the merge queue Sep 1, 2024
Merged via the queue into ublue-os:main with commit dce31e5 Sep 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants