refactor: move system updater-related logic to unified driver #31
Conversation
|
pretty nice to see that this is overall less lines than keeping it that way |
| type SystemUpdater struct { | ||
| Config DriverConfiguration | ||
| SystemDriver SystemUpdateDriver | ||
| SystemDriver SystemDriver |
There was a problem hiding this comment.
I think having seperate update drivers for rpm-ostree and bootc would be better than having a case statement in every function. The plan is to eventually deprecate rpm-ostree so it would be easier to just remove it here entirely. It would likely mean there are more LoC, but it would make more sense semantically, as they are technically different "drivers"
There was a problem hiding this comment.
This would be similar to before except likely a bit more organized
There was a problem hiding this comment.
Do you mind if I do this change on a new PR? The ones dependent on this one change it a bit because of the env changes. It should be pretty easy to split them afterwards
There was a problem hiding this comment.
Worst case I can just change it here and fix the merge conflicts
There was a problem hiding this comment.
Do you mind if I do this change on a new PR? The ones dependent on this one change it a bit because of the env changes. It should be pretty easy to split them afterwards
I don't mind, feel free to make a new PR
There was a problem hiding this comment.
Ill mark this one as a draft until then. Ill check out the other reviews and fix them first
Fixes: #30