feat: accent color support for the progress bar #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
gerblesh
requested changes
Dec 5, 2024
tulilirockz
force-pushed
the
accent-color
branch
3 times, most recently
from
a5a2009 to
b2e9c49
Compare
gerblesh
reviewed
Dec 11, 2024
…ractive progress mode
tulilirockz
force-pushed
the
accent-color
branch
from
3d04f4d to
fd526ee
Compare
|
Everything should be rebased now, I believe you can just merge this one and BAM its all merged at once. - We should just close the other issues and thats it |
gerblesh
approved these changes
Dec 13, 2024
| @@ -107,12 +67,27 @@ func NewProgressWriter() progress.Writer { | |||
| } | |||
|
|
|||
| if targetUser != 0 { | |||
| cli := []string{"gsettings", "get", "org.gnome.desktop.interface", "accent-color"} | |||
| cli := []string{"busctl", "--user", "--json=short", "call", "org.freedesktop.portal.Desktop", "/org/freedesktop/portal/desktop", "org.freedesktop.portal.Settings", "ReadOne", "ss", "org.freedesktop.appearance", "accent-color"} | |||
| out, err := RunUID(targetUser, cli, nil) | |||
There was a problem hiding this comment.
We should check the error of the cmd before unmarshalling no? Either way it works but I might just check the error here to be sure. Better safe than sorry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends: #33
Adds the BLINGEST bling you've ever seen. WITH fallbacks, so it should be completely fine!