This repository has been archived by the owner on May 2, 2024. It is now read-only.
Issue: #191, allow selecting Azure GCC High environment via aad.conf #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to allow switching between Commercial and GCC-H Azure environments
|
Everyone contributing to this PR have now signed the CLA. Thanks! |
ebarrere
force-pushed
the
environment_select
branch
from
cf65d40
to
341db0b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends functionality to allow the "azure_environment" directive in aad.conf to select Commercial or GCC-H Azure environments, updating the login endpoint appropriately. It defaults to Commercial if the variable is not set, so it should be backwards compatible.
This can easily be extended to support other environments as well, but I only have Commercial and GCC-H to test.