docs: Change to GB spelling #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1051 +/- ##
=======================================
Coverage 93.80% 93.80%
=======================================
Files 79 79
Lines 6881 6881
=======================================
Hits 6455 6455
Misses 416 416
Partials 10 10 ☔ View full report in Codecov by Sentry. |
- Changes US spellings to GB - Does not change spellings if they refer to keywords, paths or GUIs - Encloses elements (such as paths) in backticks to include US spelling where necessary without triggering spellchecker
didrocks
approved these changes
Jul 18, 2024
edibotopic
force-pushed
the
change-to-GB-spelling
branch
from
1b63b2a to
a0f92f6
Compare
|
Hey @didrocks --- this is nearly ready. It was in draft on purpose. I wanted to restore the checks on internal refs because the errors being raised were associated with a US spelling in a dir name, which then had side-effects. I'm restoring the checks because it's the default behaviour and it works fine but it was noisy during editing. This involve a lot of busy work 😄 I will merge once checks pass again. Thanks!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the default spelling in the docs from US to GB.
Spelling was fixed in text elements, such as headers and paragraphs, but was not changed when a US-spelling referred to paths, keywords or GUI element that are defined in the code/app.
Where, for example, a path or keyword needed to include a US-spelling, it was surrounded in backticks to exclude it from the spellcheck. These changes were then applied to other similar elements for consistency, even when they did not contain US-spelling.
UDENG-3525