Fix: Update e2e tests patches #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E tests are now working properly after the changes in this PR: https://github.com/ubuntu/adsys/actions/runs/12908744057 |
didrocks
reviewed
Jan 22, 2025
denisonbarbosa
force-pushed
the
fix-e2e-patches
branch
2 times, most recently
from
41ba272 to
bd07c7a
Compare
After adsys#1175, we bumped the minimum Go version to 1.23. On a toolchain level, this should not make such a difference since Go is able to update itself as needed according to what's specified in go.mod. However, the PR also introduced changes to d/control and those broke the patches that we need to apply in order to run the e2e tests.
Now that the lifecycle of Mantic is over, we don't need a patch for it anymore, but we do need a patch for Noble (golang-go is version 1.22 there), so let's reuse the Mantic patch symlink and apply it to noble instead.
denisonbarbosa
force-pushed
the
fix-e2e-patches
branch
from
bd07c7a to
6c75cba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #1175, we bumped the minimum Go version to 1.23. On a toolchain level, this should not make such a difference since Go is able to update itself as needed according to what's specified in
go.mod.However, the PR also introduced changes to d/control and those broke the patches that we need to apply in order to run the e2e tests.