tests(e2e): Base VM image generation improvements #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all actions in the first run script need to run on the first boot. Some of them we can run when preparing the VM base image itself, namely: - SSH configuration - network configuration The only part that needs to run on first boot is the hostname/hosts configuration. This will help mitigate issues with SSH not being fully initialized on boot.
Obviously this is not recommended in production, but for our testing workflows it will help being able to log in as any AD user without specifying a password and keeping track of another secret. If we do this we don't need to allow password authentication anymore.
This is not enabled by default and is needed to auto-create home directories for AD users logging in.
Codecov Report
@@ Coverage Diff @@
## main #833 +/- ##
=======================================
Coverage 86.10% 86.10%
=======================================
Files 76 76
Lines 8599 8599
=======================================
Hits 7404 7404
Misses 866 866
Partials 329 329 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details are in the commit messages, basically this tightens up the base VM provisioning part and adds some updates that will make our life easier when running tests.
I've built a noble template locally and with these changes and confirmed they work properly.