-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps(go-tools): bump github.com/golangci/golangci-lint from 1.55.2 to 1.56.2 in /tools #915
deps(go-tools): bump github.com/golangci/golangci-lint from 1.55.2 to 1.56.2 in /tools #915
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #915 +/- ##
=======================================
Coverage 87.63% 87.63%
=======================================
Files 76 76
Lines 6755 6755
=======================================
Hits 5920 5920
Misses 495 495
Partials 340 340 ☔ View full report in Codecov by Sentry. |
The easiest and safest approach to satisfy the revive linter, as these functions must have this exact signature. The occurrences were mostly split between Cobra and tests, hence the separate commits for easier review. Fixes UDENG-2287 Note that the latest version of golangci-lint (currently 1.56.2) pulls in a version of gosec where the `#nosec` directive is sort of [broken](securego/gosec#1105), hence the additional influx of warnings in the [dependabot PR](#915).
@dependabot rebase |
Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.55.2 to 1.56.2. - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md) - [Commits](golangci/golangci-lint@v1.55.2...v1.56.2) --- updated-dependencies: - dependency-name: github.com/golangci/golangci-lint dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
e504d03
to
ca5f8a6
Compare
I'm closing this and reopening the PR for 1.56.1 since gosec is bungled in this release. |
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps github.com/golangci/golangci-lint from 1.55.2 to 1.56.2.
Release notes
Sourced from github.com/golangci/golangci-lint's releases.
... (truncated)
Changelog
Sourced from github.com/golangci/golangci-lint's changelog.
... (truncated)
Commits
58a724a
build(deps): bump github.com/sashamelentyev/usestdlibvars from 1.24.0 to 1.25...a35de8c
build(deps): bump github.com/securego/gosec/v2 from 2.18.2 to 2.19.0 (#4389)71eae84
build(deps): bump github.com/go-critic/go-critic from 0.11.0 to 0.11.1 (#4388)5513d3c
build(deps): bump golang.org/x/tools from 0.17.0 to 0.18.0 (#4387)21bb543
build(deps): bump golang.org/x/oauth2 from 0.16.0 to 0.17.0 in /scripts/gen_g...5357885
build(deps): bump golangci/golangci-lint-action from 3.7.0 to 4.0.0 (#4379)403437e
docs: explain limitation of new-from-rev and new-from-patch (#4377)bf5008a
dev: handle old TODO (#4374)cc3e67b
dev: fix govet.nilness lint issues (#4373)7cf6cc9
dev: refactor govet impl with slices.Contains (#4372)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)