feat: completing the rewrite #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's taken us a while but we now have a functional server that passes the integration test suite used for the original one 🎉
I've had to copy the test suite and proto files up to
crates/ratings_newin order to be able to run the test suite correctly with the server inside of a Docker container. Not as clean as I'd originally hoped but it means we can verify the current state of things in this PR and then if we're happy we can update therewritebranch to only have the new version of the codebase in the next one. After that we can raise the PR for merging to main 💪The main change here (other than some more trait impls for proto <-> server types) is the Auth Tower Layer (most of the diff is the lockfile and duplication of the test suite). Hopefully it all makes sense (other than the generics for the trait impl its not actually complicated at all) but let me know if you want me to take you through everything.