-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve golden file error messages #207
Commits on Nov 13, 2024
-
The function does not do any dconf database filtering
Configuration menu - View commit details
-
Copy full SHA for ed031f6 - Browse repository at this point
Copy the full SHA ed031f6View commit details -
Rename CompareTreesWithFiltering -> CheckOrUpdateGoldenFileTree
* Remove the "Filtering" part from the name because the function doesn't do any filtering * Mention that it can also update the golden files
Configuration menu - View commit details
-
Copy full SHA for 0404bb6 - Browse repository at this point
Copy the full SHA 0404bb6View commit details -
Remove "update" argument from CheckOrUpdateGoldenFileTree
We don't need to pass it, the function can access the package variable instead.
Configuration menu - View commit details
-
Copy full SHA for f638255 - Browse repository at this point
Copy the full SHA f638255View commit details -
Don't nest function calls in require.NoError
Move function calls out of require.NoError for improved readability.
Configuration menu - View commit details
-
Copy full SHA for e7de8bb - Browse repository at this point
Copy the full SHA e7de8bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 126b619 - Browse repository at this point
Copy the full SHA 126b619View commit details -
Configuration menu - View commit details
-
Copy full SHA for d994038 - Browse repository at this point
Copy the full SHA d994038View commit details -
Improve the diff of mismatching golden files
Print the content in multiple lines instead of a single line.
Configuration menu - View commit details
-
Copy full SHA for d1376a0 - Browse repository at this point
Copy the full SHA d1376a0View commit details -
Colorize diff of mismatching golden files
Use delta to colorize the diff of mismatching golden files if delta is found in the PATH.
Configuration menu - View commit details
-
Copy full SHA for 9487cd7 - Browse repository at this point
Copy the full SHA 9487cd7View commit details
Commits on Nov 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 838e863 - Browse repository at this point
Copy the full SHA 838e863View commit details