Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve golden file error messages #207

Merged
merged 9 commits into from
Nov 18, 2024
Merged

Commits on Nov 13, 2024

  1. Remove obsolete comment

    The function does not do any dconf database filtering
    adombeck committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    ed031f6 View commit details
    Browse the repository at this point in the history
  2. Rename CompareTreesWithFiltering -> CheckOrUpdateGoldenFileTree

    * Remove the "Filtering" part from the name because the function
      doesn't do any filtering
    * Mention that it can also update the golden files
    adombeck committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    0404bb6 View commit details
    Browse the repository at this point in the history
  3. Remove "update" argument from CheckOrUpdateGoldenFileTree

    We don't need to pass it, the function can access the package variable
    instead.
    adombeck committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    f638255 View commit details
    Browse the repository at this point in the history
  4. Don't nest function calls in require.NoError

    Move function calls out of require.NoError for improved readability.
    adombeck committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    e7de8bb View commit details
    Browse the repository at this point in the history
  5. Rename arguments

    adombeck committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    126b619 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d994038 View commit details
    Browse the repository at this point in the history
  7. Improve the diff of mismatching golden files

    Print the content in multiple lines instead of a single line.
    adombeck committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    d1376a0 View commit details
    Browse the repository at this point in the history
  8. Colorize diff of mismatching golden files

    Use delta to colorize the diff of mismatching golden files if delta is
    found in the PATH.
    adombeck committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    9487cd7 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. Use variadic options

    adombeck committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    838e863 View commit details
    Browse the repository at this point in the history