cleanup: Use authd-defined constants for layout parsing and generation #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3v1n0
force-pushed
the
use-authd-constants
branch
2 times, most recently
from
a84eed7 to
1957847
Compare
3v1n0
force-pushed
the
use-authd-constants
branch
from
1957847 to
803b0a9
Compare
…ugging If we're not in debug mode there's no point to sprintf structures that imply allocations
The broker always define the supported entries with an optional/required prefix.
3v1n0
force-pushed
the
use-authd-constants
branch
from
803b0a9 to
31154ea
Compare
3v1n0
force-pushed
the
use-authd-constants
branch
from
31154ea to
96afa8a
Compare
…ation The same code is used twice for no reason, we can inherit what NoProvider does by default in msentra ID instead, so that's tested even more.
3v1n0
force-pushed
the
use-authd-constants
branch
from
96afa8a to
8d76d78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid using strings and manually generated maps allover the places but rely instead on the utilities that are part of ubuntu/authd#788
UDENG-5522