Skip to content

Commit

Permalink
ci: Install chromium for VHS testing
Browse files Browse the repository at this point in the history
Vhs installs chromium for testing, but it may slow downs things a bit if
done during tests (as it may be repeated), while doing it once here
avoids such issue
  • Loading branch information
3v1n0 committed Nov 23, 2024
1 parent 53185eb commit 957c746
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions .github/workflows/qa.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,10 @@ jobs:
chmod +x ttyd.x86_64
sudo mv ttyd.x86_64 /usr/bin/ttyd
- name: Install Chromium for VHS tests
# It's used by vhs, installing it once speeds up tests.
uses: browser-actions/setup-chrome@v1

- name: Install rust
if: matrix.test != 'asan'
uses: actions-rs/toolchain@v1
Expand All @@ -195,6 +199,7 @@ jobs:
if: matrix.test == 'coverage'
env:
G_DEBUG: "fatal-criticals"
VHS_NO_SANDBOX: 1
run: |
set -euo pipefail
Expand Down Expand Up @@ -229,6 +234,7 @@ jobs:
if: matrix.test == 'race'
env:
GO_TESTS_TIMEOUT: 35m
VHS_NO_SANDBOX: 1
run: |
go test -json -timeout ${GO_TESTS_TIMEOUT} -race ./... | \
gotestfmt --logfile "${AUTHD_TEST_ARTIFACTS_PATH}/gotestfmt.race.log"
Expand All @@ -243,6 +249,7 @@ jobs:
GO_TESTS_TIMEOUT: 30m
# Use these flags to give ASAN a better time to unwind the stack trace
GO_GC_FLAGS: -N -l
VHS_NO_SANDBOX: 1
run: |
# Print executed commands to ease debugging
set -x
Expand Down

0 comments on commit 957c746

Please sign in to comment.