CI: Use noble image for QA tests #641
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #641 +/- ##
==========================================
- Coverage 83.28% 83.22% -0.07%
==========================================
Files 80 80
Lines 8617 8607 -10
Branches 75 74 -1
==========================================
- Hits 7177 7163 -14
- Misses 1112 1115 +3
- Partials 328 329 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
3v1n0
force-pushed
the
ci-noble
branch
2 times, most recently
from
c579afa
to
671525e
Compare
Some tests golden files were not including the whole results, let's fix them by increasing the terminal heights.
In this way we can check for them being in golden files in a reliable way
Add an helper function to check that the golden files contains the final pam runner results strings. In this way we can ensure that the golden files sizes are big enough to hold all the terminal contents.
That's the ubuntu version we're targetting so far, and so we should care about having it working as expected when doing integration tests in particular.
When running as root or in a schroot we should not care about chrome sandbox used by VHS, so let's ignore it.
These are not needed anymore as the libPAM leaks are fixed in noble
We don't need a docker image anymore now that we're depending on 24.04
3v1n0
force-pushed
the
ci-noble
branch
4 times, most recently
from
17fd0aa
to
3618848
Compare
Vhs installs chromium for testing, but it may slow downs things a bit if done during tests (as it may be repeated), while doing it once here avoids such issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's the ubuntu version we're targetting so far, and so we should care
about having it working as expected when doing integration tests in
particular.
Regenerate the SSH golden files to match post-noble SSH server expectations.
UDENG-5316