qrcodemodel: Rate limit the emission of reselect auth mode events #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3v1n0
force-pushed
the
qrcode-rate-limit
branch
7 times, most recently
from
2f96976
to
b04fb84
Compare
denisonbarbosa
requested changes
Sep 9, 2024
3v1n0
force-pushed
the
qrcode-rate-limit
branch
from
3c0add1
to
b5a0d98
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #513 +/- ##
==========================================
- Coverage 84.75% 84.65% -0.11%
==========================================
Files 79 79
Lines 6942 6948 +6
Branches 75 75
==========================================
- Hits 5884 5882 -2
- Misses 739 743 +4
- Partials 319 323 +4 ☔ View full report in Codecov by Sentry. |
denisonbarbosa
approved these changes
Sep 10, 2024
When hitting the Enter key for a while, bubbletea sends lots of events
and we may imply sending reselectAuthMode{} events faster than we can
actually handle the cancellation/reauthModeSelection in the whole stack.
This never happened (ever) when using the example broker, but it may
actually happen in a real world scenario where the broker may not cancel
the requests quickly enough.
Do this instead of avoiding the handling of the reselectAuthMode event
because it's better to prevent bubbletea to break our (fragile) system.
3v1n0
force-pushed
the
qrcode-rate-limit
branch
from
b5a0d98
to
f3fb9ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When hitting the Enter key for a while, bubbletea sends lots of events and we may imply sending reselectAuthMode{} events faster than we can actually handle the cancellation/reauthModeSelection in the whole stack.
This never happened (ever) when using the example broker, but it may actually happen in a real world scenario where the broker may not cancel the requests quickly enough.
Do this instead of avoiding the handling of the reselectAuthMode event because it's better to prevent bubbletea to break our (fragile) system.
The change is already tested by
authenticate_user_with_qr_code_after_many_regenerationstest.UDENG-4091