Rework dbusbroker dbus calls to format errors #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now have a wrapper around the dbus calls to be able to intercept the errors and format the messages in a way that is helpful to end user. This helps avoiding error messages that are too technical, such as "the object X was not provided by any .service files" which is returned when the broker is not available on DBus. Co-authored-by: Didier Roche-Tolomelli <[email protected]>
denisonbarbosa
force-pushed
the
rework-broker-dbus-calls
branch
from
4f5465d
to
4b312ca
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #518 +/- ##
==========================================
- Coverage 84.84% 84.75% -0.10%
==========================================
Files 79 79
Lines 6942 6938 -4
Branches 75 75
==========================================
- Hits 5890 5880 -10
- Misses 736 739 +3
- Partials 316 319 +3 ☔ View full report in Codecov by Sentry. |
didrocks
approved these changes
Sep 5, 2024
didrocks
reviewed
Sep 5, 2024
3v1n0
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now have a wrapper around the dbus calls to be able to intercept the errors and format the messages in a way that is helpful to end user. This helps avoiding error messages that are too technical, such as "the object X was not provided by any .service files" which is returned when the broker is not available on DBus.
UDENG-4094