maint(pam/integration-tests): Run all the tests with a shared authd when possible #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #593 +/- ##
==========================================
- Coverage 83.28% 83.23% -0.06%
==========================================
Files 80 80
Lines 8617 8630 +13
Branches 75 75
==========================================
+ Hits 7177 7183 +6
- Misses 1112 1118 +6
- Partials 328 329 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
3v1n0
force-pushed
the
pam-tests-shared-authd
branch
2 times, most recently
from
0f3f9c6
to
4bd8ec9
Compare
We can then expose these cleanly
Use const variables to build expected example broker user names so that we can be more reliable when testing them
…er names This is valid for the standard case, while on specific cases we still rely on manual names
So we can run a shared authd for everything
… tests So that we won't clash with other test in the suite
…l tests So we can run a shared authd for everything
We removed the temporary dir on test cleanup but we may want to keep the lifecycle of the daemon bound to the daemon itself instead
The user name now has only to contain the pre-check value prefix while we don't care about its location to allow more combination of cases (such as pre-check MFA users).
… daemon The daemon is ref-counted in order to decide when killing it, so that multiple tests can share the same daemon if they want to
…nces It can be useful for debugging purposes
In case of issues it allows easier debugging
3v1n0
force-pushed
the
pam-tests-shared-authd
branch
from
4bd8ec9
to
1493b08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run by default all the tests using an unique instance of authd daemon running so that we can test better that all the codepaths work well with lots of concurrency.
Leaving this as a draft for now because it has dependencies on some commits of #583UDENG-5377