Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Midrc staging notebooks #6879

Merged
merged 8 commits into from
Dec 18, 2023
Merged

Midrc staging notebooks #6879

merged 8 commits into from
Dec 18, 2023

Conversation

cgmeyer
Copy link
Contributor

@cgmeyer cgmeyer commented Dec 14, 2023

@cgmeyer cgmeyer requested review from frankliuao and a team as code owners December 14, 2023 21:09
@cgmeyer cgmeyer added the test-portal-homepageTest run portal home page tests only label Dec 14, 2023
@cgmeyer cgmeyer removed the test-portal-homepageTest run portal home page tests only label Dec 18, 2023
paulineribeyre
paulineribeyre approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@paulineribeyre paulineribeyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing (revproxy crashing) but it shouldn't be caused by these changes. Merging

@paulineribeyre paulineribeyre merged commit e0fe7f5 into master Dec 18, 2023
1 check passed
@paulineribeyre paulineribeyre deleted the midrc_staging_notebooks branch December 18, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulineribeyre paulineribeyre paulineribeyre approved these changes

@frankliuao frankliuao Awaiting requested review from frankliuao frankliuao is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgmeyer @paulineribeyre