Argo Changes to Allow Workflow Runs From All NS #2360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…this case, we need this functionality to be able to run the "usersync" argo workflow job and usersync must run in the namespace in question and not in the "argo" namespace.
…d allow for multiple namespace to use a role.
…erly to all functions. Also, adding in the "--flag" option in the kube-setup-argo script and removing the rolebindingcommand for the argo SA as it is no longer needed.
…rom kube-setup-argo as roles are cluster based now.
…er namespaces while still allowing the "default" service account admin access in the argo namespace.
…as usersync must be run in the same namespace as fence.
…adding a line to create the argo sa
…mespaces trust policy so the same key is not used.
emalinowski
previously approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
making changes to allow argo workflows to run from any namespace. In this case, we need this functionality to be able to run the "usersync" argo workflow job and usersync must run in the namespace in question and not in the "argo" namespace.