GPE-1122 adding logic to exit a gitops sync if the new json contains invalid json #2377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulineribeyre
changed the title
paulineribeyre
approved these changes
Oct 6, 2023
| echo "old JSON is: $oldJson" | ||
| echo "new JSON is: $newJson" | ||
| newJson=$(g3k_config_lookup ".versions") |
There was a problem hiding this comment.
I think this update will make sure it fails if any part of the manifest is invalid json, not just the "versions" section, if that's the case could you update the PR description
There was a problem hiding this comment.
yes! Thanks so much Pauline :D Just updated the description
emalinowski
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested manually
Improvements
gitops sync will fail if there is a json syntax error anywhere in the manifest.json