Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/check and update fence jobs #2564

Merged
merged 9 commits into from
Jun 11, 2024
Merged

Conversation

ajoaugustine
Copy link
Contributor

@ajoaugustine ajoaugustine commented Jun 6, 2024

New Features

check and update fence cronjobs during gitops sync to make sure they use the latest image specified in the manifest.

@jawadqur jawadqur requested a review from BinamB June 6, 2024 15:37
@jawadqur
Copy link
Contributor

jawadqur commented Jun 6, 2024

Adding @BinamB to the review as well, this will make sure we keep updating the cronjobs if they exist for fence, right now a lot of these jobs are in error state as they do not get updated, and are running very old versions of fence.

@ajoaugustine
Copy link
Contributor Author

Adding @BinamB to the review as well, this will make sure we keep updating the cronjobs if they exist for fence, right now a lot of these jobs are in error state as they do not get updated, and are running very old versions of fence.

Here are the logs from a test run.

changes detected, rolling
INFO: 17:25:33 - Checking cronjob fence-delete-expired-clients...
INFO: 17:25:34 - Updating cronjob fence-delete-expired-clients ...
cronjob.batch/fence-delete-expired-clients created
...
...
INFO: 17:25:42 - Checking cronjob fence-cleanup-expired-ga4gh-info...
INFO: 17:25:44 - Updating cronjob fence-cleanup-expired-ga4gh-info ...
cronjob.batch/fence-cleanup-expired-ga4gh-info created

BinamB
BinamB previously approved these changes Jun 6, 2024
jawadqur
jawadqur previously approved these changes Jun 6, 2024
Copy link
Contributor

@jawadqur jawadqur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 😄

@ajoaugustine ajoaugustine merged commit 7283efe into master Jun 11, 2024
4 of 5 checks passed
@ajoaugustine ajoaugustine deleted the feat/check-and-update-fence-jobs branch June 11, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants