-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reload workspace options on paymodel change #1447
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulineribeyre
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome
PlanXCyborg
added
test-portal-coremetadatapageTest
test-portal-exportToWorkspaceTest
and removed
@requires-portal
labels
Nov 2, 2023
jarvisraymond-uchicago
pushed a commit
that referenced
this pull request
Nov 8, 2023
jarvisraymond-uchicago
added a commit
that referenced
this pull request
Nov 14, 2023
* feat: allow teamProject to be configured in gitops.json instead of hard-coding in frontend code * feat: allow for appId property in app definition ...and if set, use that instead of "title" * feat: added analysisTools section documentation to portal_config.md * fix: revert back the old GWAS app names ...so navigation can work again as before * feat(addTeamProjecHeaderToAnalysisApps): Added header without logic to redirect * feat(addTeamProjectHeaderToAnalysisApps): added redirect logic * feat(addTeamProjectHeaderToAnalysisApps): Got test to work for TeamProjectHeader conditional * feat(addTeamProjectHeaderToAnalysisApps): Ran eslint-new * feat(addTeamProjectHeaderToAnalysisApps): Removed unneeded async declaration * feat(addTeamProjectHeaderToAnalysisApps): Removed unneeded waitFor import * feat(addTeamProjectHeaderToAnalysisApps): Fixed lint issues * feat(addTeamProjectHeaderToAnalysisApps): Removed header element to make styles more consistent across applications * feat(addTeamProjectHeaderToAnalysisApps): Removed unneeded comments * feat(addTeamProjectHeaderToAnalysisApps): Ran linter * feat(addTeamProjectHeaderToAnalysisApps): Changed all instances of variable name showButton to isEditable * feat(addTeamProjectHeaderToAnalysisApps): updated storybook for clarity * Reload workspace options on paymodel change (#1447) * feat(teamProjectApiUpdate): Initial commit * feat(teamProjectApiUpdate): Added API update for results app * Chore(deps-dev): Bump @babel/traverse from 7.22.5 to 7.23.2 (#1440) Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.22.5 to 7.23.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat(teamProjectApiUpdate): Added conditional in AnalysisApp.jsx for OHDSI Atlas app iframe URL * feat(teamProjectApiUpdate): Refactored initializeCurrentState for terseness * feat(teamProjectApiUpdate): updated API endpoint per change in BE * feat(teamProjectApiUpdate): updated data passed to HomeTable component to support change in BE response * feat(teamProjectApiUpdate): updated data passed to HomeTable test to support change in BE response * feat(teamProjectApiUpdate): Reverted change on FE to deal with BE change in DS, BE change was inadvertant * feat(teamProjectApiUpdate): Reverted unintentionally changed files * feat(teamProjectApiUpdate): Removed unneeded console log statement * feat(teamProjectApiUpdate): Changed OHSDI iframe src string based on discussed with BE dev * feat(vadc_sprint22): Added sanitize function for team project variable * feat(vadc_sprint22): Added const var for team project variable * feat(vadc_sprint22): Refactored to use class function getAtlastURLWithTeamProject * feat(vadc_sprint22): Autoformatted code * feat(vadc_sprint22): Updated regex and test for regex * feat(vadc_sprint22): formatted Code for linter * feat(vadc_sprint22): Updated regex and autoformatted code * feat(vadc_sprint22): Reverted changes for snyk * feat(vadc_sprint22): updated regex and added throw error * fix: let teamproject be added to Atlas only if the needsTeamProject flag is set --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: pieterlukasse <[email protected]> Co-authored-by: Sai Shanmukha Narumanchi <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: BRH-486
Bug Fixes