Feat/team project api update #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.22.5 to 7.23.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…OHDSI Atlas app iframe URL
…t to support change in BE response
…support change in BE response
…nge in DS, BE change was inadvertant
jarvisraymond-uchicago
changed the base branch from
master
to
feat/vadc_sprint22
src/Analysis/AnalysisApp.jsx
Outdated
| src={`${this.state.app.applicationUrl}`} | ||
| src={ | ||
| this.state.app.title === 'OHDSI Atlas' | ||
| ? `${this.state.app.applicationUrl}?teamproject=${localStorage.getItem('teamProject')}` |
There was a problem hiding this comment.
Suggested change
| ? `${this.state.app.applicationUrl}?teamproject=${localStorage.getItem('teamProject')}` | |
| ? `${this.state.app.applicationUrl}#/home?teamproject=${localStorage.getItem('teamProject')}` |
…discussed with BE dev
pieterlukasse
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: VADC-761
User is able to select a team project now, this information is passed to BE so user can view data associated only with the selected team project in Results app and OHDSI Atlas. Filtering of data by team project for Gen3 GWAS will be handled in a separate ticket.
New Features