Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated copy feature/OIDC oauth groups rev2 #1233

Open
wants to merge 58 commits into
base: master
Choose a base branch
from
Open

Automated copy feature/OIDC oauth groups rev2 #1233

wants to merge 58 commits into from

Conversation

Avantol13
Copy link
Contributor

Link to JIRA ticket if there is one:

New Features

Breaking Changes

Bug Fixes

Improvements

Dependency updates

Deployment changes

uwwint and others added 30 commits September 26, 2024 20:57
@uwwint @flashguerdon
added plan
25d1654
@flashguerdon
Use idp groups
96300d4
@flashguerdon
remove print
d8d0955
@flashguerdon
tests updates
5dfdd7b
@flashguerdon
test fixes
05c04c8
@flashguerdon
Code update and Unit Test
724b76f
@uwwint @flashguerdon
merge upstream
dd8efdd
@flashguerdon
check group flag
388cf69
@flashguerdon
testing
d77cec3
@flashguerdon
Unit Test updates
bcbcee5
@flashguerdon
token refreshing
c5c0519
@flashguerdon
refresh token update
5ec4fb7
@flashguerdon
Renaming to AccessTokenUpdater, unit testing
6f30aeb
@flashguerdon
fixed tests
10c59ec
@flashguerdon
Updated tests
d3419d5
@flashguerdon
Use OAuth user groups and implementation of token refresh in fence.
3692d79
@flashguerdon @Avantol13
Update fence/resources/openid/idp_oauth2.py
2984f05 
remove trailing space

Co-authored-by: Alexander VanTol <[email protected]>
@flashguerdon
Code revision and refactoring
b125321
@flashguerdon
Remove new Arborist client instance
18336df
@flashguerdon
Re-add Arborist client, to fix fence_create update-visas job
4645494
@flashguerdon
2nd revision
7008e94
@flashguerdon
check group sync config on startup
d0074f5
@flashguerdon
added test for generic3
55cfdc4
@paulineribeyre @flashguerdon
Add link to user.yaml guide
ab7dcfa
@pieterlukasse @flashguerdon
feat: config with option to allow only existing OR active users to login
8520425
@pieterlukasse @flashguerdon
feat: remove unnecessary else
7774fc9
@pieterlukasse @flashguerdon
fix: remove unnecessary code
7300d99
@pieterlukasse @flashguerdon
feat: add extra fields to /admin/user POST endpoint
3869656 
...to make user creation more uniform, reflecting what is also done elsewhere
in fence/sync/sync_users.py _upsert_userinfo() for example
@pieterlukasse @flashguerdon
fix: fix tests/admin
39d5217
@pieterlukasse @flashguerdon
feat: add extra debug logging to create_user method
ab6e17d
pieterlukasse and others added 27 commits November 8, 2024 11:23
@pieterlukasse @flashguerdon
fix: store tags and add unit test for tags and new fields
0d72ec7
@pieterlukasse @flashguerdon
feat: update dependencies
659bf5a
@pieterlukasse @flashguerdon
fix: add docstring to new test
d791800
@pieterlukasse @flashguerdon
feat: improve unit test checks on error messages
f1b8e31
@mfshao @flashguerdon
Fix/bucket name (#1193)
bd28aba 
* fix use real bucket name

* fix

* update comment

* use regex

* update version
@ocshawn @flashguerdon
Update documentation link in setup.md (#1194)
67c318c 
Update documentation link in setup.md
@pieterlukasse @flashguerdon
feat: udpate admin_login_required decorator
436c08a
@pieterlukasse @flashguerdon
fix: update /admin/user tests to mock arborist call
d546b02
@pieterlukasse @flashguerdon
feat: add rainy path test for when arborist check fails
cd810a1
@flashguerdon
Merge branch 'master' into feature/oidc-oauth-groups
a5ccac6
@flashguerdon
reverted host option
90667c3
@flashguerdon
Merge branch 'master' into feature/oidc-oauth-groups
3cb11a7
@flashguerdon
fixed group membership removal
7c5cbe4
@flashguerdon
revised group expiration
8c4240a
@flashguerdon
update unit tests
ad34cd0
@flashguerdon
use public keys, update tests
af4e4c5
@flashguerdon
remove --no-dev option
9839132
@flashguerdon
bug fix, access token instead of id token
c95cc60
@flashguerdon
log access token for debugging
9cf9a2c
@flashguerdon
log access token for debugging
32e37d1
@flashguerdon
bug fix, use access_token
92c2694
@flashguerdon
bug fix, use access_token
baf42d4
@flashguerdon
user registration
81a2a84
@flashguerdon
automatic user registation from idp
88f5198
@flashguerdon
cilogon unit test
a630b37
@flashguerdon
Merge branch 'feature/user-registration' into feature/oidc-oauth-grou…
aec0fc9 
…ps-rev2
@flashguerdon
Merge remote-tracking branch 'origin' into feature/oidc-oauth-groups-…
aac9690 
…rev2
@Avantol13 Avantol13 mentioned this pull request Mar 11, 2025
Closed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13791458031

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 174 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-0.4%) to 74.828%
Files with Coverage Reduction New Missed Lines %
error_handler.py 1 97.92%
resources/openid/microsoft_oauth2.py 1 95.0%
resources/openid/google_oauth2.py 2 80.0%
init.py 3 90.84%
resources/openid/okta_oauth2.py 3 50.0%
resources/openid/orcid_oauth2.py 3 50.0%
resources/openid/cognito_oauth2.py 4 43.48%
config.py 5 72.31%
scripting/fence_create.py 5 60.35%
blueprints/login/base.py 50 65.31%
Totals Coverage Status
Change from base Build 13727753577: -0.4%
Covered Lines: 7943
Relevant Lines: 10615
💛 - Coveralls

@github-actions GitHub Actions
Copy link

filepath $$\textcolor{#23d18b}{\tt{passed}}$$ $$\textcolor{#f14c4c}{\tt{failed}}$$ $$\textcolor{#ffa500}{\tt{skipped}}$$ SUBTOTAL
$$\textcolor{#23d18b}{\tt{tests/test\_oauth2.py}}$$ $$\textcolor{#23d18b}{\tt{15}}$$ $$\textcolor{#666666}{\tt{0}}$$ $$\textcolor{#666666}{\tt{0}}$$ $$\textcolor{#23d18b}{\tt{15}}$$
$$\textcolor{#23d18b}{\tt{tests/test\_centralized\_auth.py}}$$ $$\textcolor{#23d18b}{\tt{16}}$$ $$\textcolor{#666666}{\tt{0}}$$ $$\textcolor{#666666}{\tt{0}}$$ $$\textcolor{#23d18b}{\tt{16}}$$
$$\textcolor{#ffa500}{\tt{tests/test\_data\_upload.py}}$$ $$\textcolor{#23d18b}{\tt{8}}$$ $$\textcolor{#666666}{\tt{0}}$$ $$\textcolor{#ffa500}{\tt{1}}$$ $$\textcolor{#ffa500}{\tt{9}}$$
$$\textcolor{#23d18b}{\tt{tests/test\_presigned\_url.py}}$$ $$\textcolor{#23d18b}{\tt{7}}$$ $$\textcolor{#666666}{\tt{0}}$$ $$\textcolor{#666666}{\tt{0}}$$ $$\textcolor{#23d18b}{\tt{7}}$$
$$\textcolor{#23d18b}{\tt{tests/test\_user\_token.py}}$$ $$\textcolor{#23d18b}{\tt{5}}$$ $$\textcolor{#666666}{\tt{0}}$$ $$\textcolor{#666666}{\tt{0}}$$ $$\textcolor{#23d18b}{\tt{5}}$$
$$\textcolor{#ffa500}{\tt{tests/test\_dbgap.py}}$$ $$\textcolor{#23d18b}{\tt{4}}$$ $$\textcolor{#666666}{\tt{0}}$$ $$\textcolor{#ffa500}{\tt{1}}$$ $$\textcolor{#ffa500}{\tt{5}}$$
$$\textcolor{#23d18b}{\tt{tests/test\_drs\_endpoint.py}}$$ $$\textcolor{#23d18b}{\tt{4}}$$ $$\textcolor{#666666}{\tt{0}}$$ $$\textcolor{#666666}{\tt{0}}$$ $$\textcolor{#23d18b}{\tt{4}}$$
$$\textcolor{#23d18b}{\tt{tests/test\_ras\_authn.py}}$$ $$\textcolor{#23d18b}{\tt{3}}$$ $$\textcolor{#666666}{\tt{0}}$$ $$\textcolor{#666666}{\tt{0}}$$ $$\textcolor{#23d18b}{\tt{3}}$$
$$\textcolor{#23d18b}{\tt{tests/test\_google\_data\_access.py}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#666666}{\tt{0}}$$ $$\textcolor{#666666}{\tt{0}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{tests/test\_oidc\_client.py}}$$ $$\textcolor{#23d18b}{\tt{2}}$$ $$\textcolor{#666666}{\tt{0}}$$ $$\textcolor{#666666}{\tt{0}}$$ $$\textcolor{#23d18b}{\tt{2}}$$
$$\textcolor{#23d18b}{\tt{tests/test\_client\_credentials.py}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#666666}{\tt{0}}$$ $$\textcolor{#666666}{\tt{0}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#ffa500}{\tt{tests/test\_register\_user.py}}$$ $$\textcolor{#666666}{\tt{0}}$$ $$\textcolor{#666666}{\tt{0}}$$ $$\textcolor{#ffa500}{\tt{2}}$$ $$\textcolor{#ffa500}{\tt{2}}$$
$$\textcolor{#f14c4c}{\tt{tests/test\_audit\_service.py}}$$ $$\textcolor{#666666}{\tt{0}}$$ $$\textcolor{#f14c4c}{\tt{1}}$$ $$\textcolor{#666666}{\tt{0}}$$ $$\textcolor{#f14c4c}{\tt{1}}$$
$$\textcolor{#f14c4c}{\tt{TOTAL}}$$ $$\textcolor{#23d18b}{\tt{66}}$$ $$\textcolor{#f14c4c}{\tt{1}}$$ $$\textcolor{#ffa500}{\tt{4}}$$ $$\textcolor{#f14c4c}{\tt{71}}$$

Please find the detailed integration test report here

Please find the ci env pod logs here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Avantol13 @coveralls @flashguerdon @uwwint @paulineribeyre @pieterlukasse @mfshao @ocshawn