-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP feat(redis): redis client and caching logic #264
Open
Avantol13
wants to merge
9
commits into
master
Choose a base branch
from
feat/redis
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
Comment on lines
+223
to
+228
# check redis | ||
json_record = flask.current_app.redis_client.get(record) | ||
if json_record: | ||
json_record = json.loads(json_record) | ||
else: | ||
# get from db |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in fence i do: check redis; if not in redis: call indexd
so i think we could skip checking redis again here. 3 cases:
- request to indexd from another service: we can assume the other service already checked the cache
- request from a user: now that the request reached indexd, it's too late to improve performance
- the record is in redis: getting from redis instead of the DB doesn't improve performance (i think)
- it's not in redis: performance is decreased since indexd checks both
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-->
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes