-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Indexes to Single Table #386
base: master
Are you sure you want to change the base?
Conversation
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
Please find the detailed integration test report here Please find the ci env pod logs here |
file_name = Column(String) | ||
version = Column(String) | ||
uploader = Column(String) | ||
file_name = Column(String, index=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should be this generous with indexing. There are drawbacks on insertion and other considerations. I don't think you should index on anything other than size
, hashes
. guid and baseid should already be indexed.
What prompted the addition of all of these?
Please find the ci env pod logs here |
Please find the ci env pod logs here |
Link to JIRA ticket if there is one:
New Features
Breaking Changes
Bug Fixes
Improvements
record
tableDependency updates
Deployment changes
b61e2d4aa93d