Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add start.sh to correct build stage #36

Merged
merged 3 commits into from
Jan 2, 2025
Merged

Add start.sh to correct build stage #36

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
079afaa
Add start.sh to correct build stage
jawadqur Jan 2, 2025
c03690e
update Docker and start.sh
craigrbarnes Jan 2, 2025
2168f0e
update Docker and start.sh
craigrbarnes Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
COPY ./src ./src
COPY ./public ./public
COPY ./config ./config
COPY ./start.sh ./
RUN npm install @swc/core @napi-rs/magic-string && \
npm run build

Expand All @@ -21,10 +20,12 @@
RUN addgroup --system --gid 1001 nextjs && \
adduser --system --uid 1001 nextjs

COPY --from=builder /gen3/node_modules ./node_modules
COPY --from=builder /gen3/config ./config
COPY --from=builder /gen3/public ./public
COPY --from=builder /gen3/.next/static ./.next/static
COPY --from=builder --chown=nextjs:nextjs /gen3/.next ./.next
COPY --from=builder /gen3/start.sh /gen3/package.json ./

USER nextjs
ENV PORT=3000
CMD bash ./start.sh

Check warning on line 31 in Dockerfile

View workflow job for this annotation

GitHub Actions / Build Image and Push to Quay / Build Image and Push

JSON arguments recommended for ENTRYPOINT/CMD to prevent unintended behavior related to OS signals 

JSONArgsRecommended: JSON arguments recommended for CMD to prevent unintended behavior related to OS signals
More info: https://docs.docker.com/go/dockerfile/rule/json-args-recommended/
Loading