remove unused pkg and update deps #126
Conversation
src/pfb/importers/gen3dict.py
Outdated
| @@ -275,7 +275,10 @@ def _array_type(property_type): | |||
| if "description" in property_type: | |||
| enum["name"] = property_type["description"] | |||
| else: | |||
| enum["name"] = property_type["termDef"][0]["term"] | |||
| enum["name"] = property_type["term"]["termDef"]["term"] | |||
There was a problem hiding this comment.
suggestion: This block can be rewritten as
enum["name"] = (
property_type.get("description") or
property_type["term"]["termDef"]["term"] or
property_type["termDef"][0]["term"])There was a problem hiding this comment.
yeah I was suppose to write this using .get() somehow I just forgot 🤦
src/pfb/importers/gen3dict.py
Outdated
| @@ -275,7 +275,10 @@ def _array_type(property_type): | |||
| if "description" in property_type: | |||
| enum["name"] = property_type["description"] | |||
| else: | |||
| enum["name"] = property_type["termDef"][0]["term"] | |||
| enum["name"] = property_type["term"]["termDef"]["term"] | |||
There was a problem hiding this comment.
This should exist but should we do something safer like property_type.get("term", None).get("termDef").get("term") so we know we get a None returned
There was a problem hiding this comment.
yeah I was suppose to write this using .get() somehow I just forgot 🤦
There was a problem hiding this comment.
defaulting to None will still be unsafe. If you want to be safe I believe the format would be
result = property_type.get("term", {}).get("termDef", {}).get("term")
There was a problem hiding this comment.
yeah this is the right way
Link to JIRA ticket if there is one: https://ctds-planx.atlassian.net/browse/HP-1589
Improvements
Dependency updates