Fastavro floating number imprecision #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlbertSnows
reviewed
Jan 7, 2025
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| from ..cli import from_command | |||
|
|
|||
| _AVRO_TYPES = {"integer": "long", "number": "float", "int": "long"} | |||
| _AVRO_TYPES = {"integer": "long", "number": "double", "int": "long"} | |||
There was a problem hiding this comment.
Suggestion: swap magic string with a constant, makes for fewer changes in the future. although...in a case like this it would be the same number of changes either way, so maybe this suggestion is pointless?
There was a problem hiding this comment.
personally I don't see an advantage in changing this at the moment, we could revisit later
AlbertSnows
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ctds-planx.atlassian.net/browse/PXP-11430
Bug Fixes
Use correct fastavro type for floating number to prevent imprecision
Improvements
Update detect-secrets and black version
remove unused trufflehog secret detection.