Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client support for NLPRP tabular schema #180

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

RudolfCardinal
Copy link
Collaborator

We'd designed the specification, but not implemented it properly client-side. Now this matters!

@RudolfCardinal RudolfCardinal marked this pull request as draft December 18, 2024 17:18
@RudolfCardinal
Copy link
Collaborator Author

This change implements the client aspects of the tabular_schema option in the NLP Request Protocol (NLPRP); https://crateanon.readthedocs.io/en/latest/nlp/nlprp.html#list-processors.

There's an end-to-end test in the test suite that creates an SQLite database (requiring a few minor tweaks) and sets up a client-server pair. The client asks the server for its NLP definitions, then sets up a couple of database tables based on that. To be safe, remote table names aren't trusted, but if you map a remote table name to an empty definition, it'll use the remote tabular_schema structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants