Require first & last name on project requests#637

Open

helbashandy wants to merge 18 commits intodevelopfrom issue-605-require-first-last-name

+955-79

Commits on Sep 26, 2024

Method for renewing ICAs

adeng27
authored and
helbashandy
committed
disallow non ICA projects

adeng27
authored and
helbashandy
committed
Find PI

adeng27
authored and
helbashandy
committed
Ensure requester is a part of the project. Stop requests for out of date allocation periods.

adeng27
authored and
helbashandy
committed
Remove todo

adeng27
authored and
helbashandy
committed
changes based off pr comments

adeng27
authored and
helbashandy
committed
Initial unit testing

adeng27
authored and
helbashandy
committed
Basic unit testing for key assumptions

adeng27
authored and
helbashandy
committed
Refactor logic for fetching the AllocationPeriods pertinent to a particular allowance type into a method

matthew-li
authored and
helbashandy
committed
Refactor logic for setting PI eligibility in renewal request into method

matthew-li
authored and
helbashandy
committed
Refactor logic for computing SUs to allocate to new project request/renewal request into method

matthew-li
authored and
helbashandy
committed
Generalize projects command > renew to enable renewals of non-pooling FCAs and PCAs; add constraints

matthew-li
authored and
helbashandy
committed
Add comments describing additional test cases for projects command > renew

matthew-li
authored and
helbashandy
committed
flesh out testing for project renewals

adeng27
authored and
helbashandy
committed
Disallow renewals of limited-per-PI allowances until checks added; add/fix tests

matthew-li
authored and
helbashandy
committed
Decorate renewal tests as being BRC tests

matthew-li
authored and
helbashandy
committed
Remove entry from .gitignore

matthew-li
authored and
helbashandy
committed

Commits on Oct 8, 2024

Require first & last name on project requests
helbashandy
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Require first & last name on project requests#637

Commits on Sep 26, 2024

Method for renewing ICAs

disallow non ICA projects

Find PI

Ensure requester is a part of the project. Stop requests for out of date allocation periods.

Remove todo

changes based off pr comments

Initial unit testing

Basic unit testing for key assumptions

Refactor logic for fetching the AllocationPeriods pertinent to a particular allowance type into a method

Refactor logic for setting PI eligibility in renewal request into method

Refactor logic for computing SUs to allocate to new project request/renewal request into method

Generalize projects command > renew to enable renewals of non-pooling FCAs and PCAs; add constraints

Add comments describing additional test cases for projects command > renew

flesh out testing for project renewals

Disallow renewals of limited-per-PI allowances until checks added; add/fix tests

Decorate renewal tests as being BRC tests

Remove entry from .gitignore

Commits on Oct 8, 2024

Require first & last name on project requests