RAPS fixes and LDAP fixes #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm sure there will be additional back-and-forth, but here's the next round of changes: --- [Permission(Allow = "SVMSecure")] is probably a sufficient permission check. As it is now, this restricts the page to a much smaller set of users. Done --- Make sure to remove copy/pasted variables that are not needed in this class Sorry about that; I had left in some of my early code (as I was trying to figure out how all this works!). I removed the variables, but I added back in what seemed necessary to do the permission check. --- We might need a permission check here for the IDs. Since this data is sent to the browser via AJAX, it's visible to the user, even if not included in the page. One way to handle this would be the IndividualSearchResult class only containing data visible to everyone, and then an IndividualSearchResultWithIds child class containing the restricted data. Maybe you can help me think about a better way of doing this. I couldn't quite figure out how to use a generic to be able to switch between the two possible resulting objects. --- There's a static function GetOldViperRootURL() in HttpHelper that could be used to get the url for Viper on the current server, instead of hard coding viper.vetmed. Good tip. Thanks! Its seems like vue isn't very happy with localhost, but maybe adding a local certificate will help with some of the problems I am now getting. --- The key for the storage has to be unique across all of VIPER, so consider prefixing searchField with, e.g. directory or some other prefix. Fixed. I am now using directory_search --- I know I used 3 as the min length for RAPS, but it's been suggested to me that 2 might be better. Good suggestion. Fixed. --- Consider allowing additional ID searches - pidm, spriden id, mothra id, employee id, iam id Done --- I'm glad you were able to use this class! I added phone number to the LDAP lookup. If that is getting too unwieldy, we could pull it out of RAPS and create a generic LDAPlookup class.
This is all pretty messy, but I think I can unwrap the debugging stuff once we figure out the error. The current message at /directory/search/francis/ucd is "DirectoryServicesCOMException: An invalid dn syntax has been specified." I thought the invalid username message I was getting earlier was an indication that at least the username/password was correct, but I am getting the invalid dn error even with [username] and [password]. Every filter string I have tried has returned the same error.
Next step is exploring cards for display instead of the table. I will focus more on making sure all the relevant data is displayed with the next update.
…into feature/directory
# Conflicts: # web/Areas/RAPS/Services/LdapService.cs
This reverts commit ed3ce5d.
…es in the Utilities folder. Updating LDAP result properties to match properties from CF directory code.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
JasonRobertFrancis
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing Active Directory LDAP in RAPS and LDAP in the Directory by using System.DirectoryServices.Protocols.
Splitting LDAP and ActiveDirectory into their own classes in Classes/Utilities.
Minor fixes for RAPS.
Directory code will be deployed to prod so we can make sure prod is working, but it's been locked to SVM-IT for now.