-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/1336 add option to hide assets in importer #130
base: dev/2.4.0
Are you sure you want to change the base?
Issue/1336 add option to hide assets in importer #130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parts of the code could be clarified and cleaned up, and the new method in Materia.Coms.Json
is not currently using provided objects properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR includes the original .obj support code that was merged and added to MSCA 2.4.0 via a different PR. I would merge the current master into this branch and resolve the conflicts related to the .obj support code (prefer incoming changes), so the diff is clean with only the changes required for hiding/displaying deleted assets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking better, just one section that needs to be removed.
}) | ||
}); | ||
|
||
// obj file extensions MIME_TYPE changes based on upload or download. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section (from lines 162 through 172) is still from the now obsolete obj support code and should be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed it
Changes are done to the media importer to support the deletion of assets. Also, modifications were done to establish communication between the DB and the Client.