Implement testing for Multiclass_longdesc and Multiclass_shortdesc #1633
Conversation
…ny meaningful tests. I expect to finish this task tomorrow
…tions into multiclass.c
… the success out parameters
…t repeated multiple times in a multicalss shortdesc
… are getting committed
…s included final periods
…s 2 too high" This reverts commit 51bc5ff.
…d pushes are getting committed" This reverts commit 782adb9.
There was a problem hiding this comment.
This looks great! In multiclass.c there are a number of lines past 80 characters, which I understand due to all the struct calling, but some of them could be broken up between function arguments and put on new lines to limit the length of the lines. There's also a function definition with a lot of parameters that goes over 80 lines, but I'm not sure if that's something that should be split up. I also noticed a few typos in the file, which I commented. But the tests look very comprehensive, they cover a lot of scenarios. And the functions in multiclass.c look well written. Aside from the few formatting things I commented, this seems to be in great shape!
|
In this PR, we have done some major debugging and performance fixing in the multiclass_shortdesc and multiclass_longdesc functions. We have also implemented complete tests for them |
this is the closing statement, jumped the gun on it a bit there |
|
Issue Score: Excellent Comments: |
The new multiclass has several functions, and they all need to be tested. This pull request implements multiclass_longdesc, multiclass_shortdesc and their tests. Currently, the tests account for grammar, string overflow, and overall functionality within the two functions. Additionally, it debugs the multiclass function and a few of the other functions in the multiclass module. This pull request is the first step in finishing issue #1608.