Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UCL_2024061800 #10

Open
wants to merge 2 commits into
base: UCL_2024032901
Choose a base branch
from
Open

UCL_2024061800 #10

wants to merge 2 commits into from

Conversation

opitz
Copy link

@opitz opitz commented Jun 18, 2024

I have added two fixes for now deprecated function usages:

  • current() now no longer accepts objects as parameters, so casting them into an array first fixes this.
  • is_nan() no longer accepts null as a parameter. Checking if parameter is null before will fix this.

Maybe not merge but use this branch as the new default?

@opitz opitz requested review from aspark21 and dragos5436 June 18, 2024 09:51
@aspark21
Copy link
Collaborator

@opitz have you submitted these upstream https://github.com/turnitin/moodle-mod_turnitintooltwo ?

where is this causing issues at the moment? just feedback tracker?

@opitz
Copy link
Author

opitz commented Jun 18, 2024

@aspark21 yes, PR created upstream: turnitin#728
The issue appears as well when trying to follow the link in my_feedback report (it is not related to report_feedback_tracker!).
The issue only shows when debug is set to DEVELOPER.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants