Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Initiative Descriptions and Member Page #113

Merged
merged 13 commits into from
Sep 21, 2023

Conversation

ssalandary
Copy link
Contributor

Summary

Closes #85

Create initiative descriptions and add to "About" Page of site. Move all member-specific content to a dedicated "members" page.

@bliutech bliutech mentioned this pull request Sep 21, 2023
Copy link
Member

@bliutech bliutech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let me add @Arc-blroth as a reviewer just to get a second pair of eyes on the styling changes I made.

@bliutech
Copy link
Member

🤡

Copy link
Member

@Arc-blroth Arc-blroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • we should probably add an image to the members page
  • i'm slightly worried about the duplication of the cyberThing class across the Home.module.scss and About.module.scss, but it should be fiiiiiiiine
  • benson just reminded me we need to fixup the links in home so lemme do that

Copy link
Member

@Arc-blroth Arc-blroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

appears satisfactory from my perspective

@Arc-blroth Arc-blroth merged commit f7df18c into main Sep 21, 2023
@Arc-blroth Arc-blroth deleted the salma/initiative-descriptions branch September 21, 2023 22:59
burturt pushed a commit that referenced this pull request Jan 10, 2024
Feat: Initiative Descriptions and Member Page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Initative Descriptions
3 participants