Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter repos in projects page by ucla-opensource tag #155

Merged
merged 5 commits into from
Mar 4, 2024

Conversation

Amyh11325
Copy link
Contributor

@Amyh11325 Amyh11325 commented Feb 6, 2024

What

Before, all repos and good first issues in the uclaacm org are shown on the projects page
After, only repos in the uclaacm org with the ucla-opensource topic are shown. And only good first issue topics inside repos with the ucla-opensource topic are shown.

Why

Not all ucla acm repos are opensource and should be displayed on the website. Some repos are public but editors are limited to committee officers.

Code Changes

Quick change, just filtered out all repos without the topic.

Testing Repos

  1. Ran yarn dev and opened localhost
  2. Went to the Projects page and checked that the projects listed there match all the projects that currently have the ucla-opensource topic in the uclaacm org

Opensource Projects:
Screen Shot 2024-02-05 at 7 44 13 PM

Github Search
Screen Shot 2024-02-05 at 7 44 46 PM

Testing Good First Issues

  1. Ran yarn dev
  2. Went to http://localhost:3000/contribute#good-first-issues and checked that only repos with ucla-opensource topic are shown

Before:
Screen Shot 2024-02-22 at 6 38 12 PM

After:
Screen Shot 2024-02-22 at 6 37 24 PM

@Amyh11325
Copy link
Contributor Author

Should I filter the live feed and good first issues too? Imo it's ok for the live feed to show everything, but I'm not sure if the good first issues tag is used exclusively for open source projects.

@ArshMalik02
Copy link

Should I filter the live feed and good first issues too? Imo it's ok for the live feed to show everything, but I'm not sure if the good first issues tag is used exclusively for open source projects.

@Amyh11325 we should filter the good first issues to be only coming from repos that have ucla-opensource as one of the topics. We can leave the live feed as is. Check out this issue #156 that details the tasks we need to do to make this transition.

You can modify this PR to meet the two tasks- filter the repos and filter the good first issues.

Let me know if you have any questions!

@Amyh11325
Copy link
Contributor Author

Should I filter the live feed and good first issues too? Imo it's ok for the live feed to show everything, but I'm not sure if the good first issues tag is used exclusively for open source projects.

@Amyh11325 we should filter the good first issues to be only coming from repos that have ucla-opensource as one of the topics. We can leave the live feed as is. Check out this issue #156 that details the tasks we need to do to make this transition.

You can modify this PR to meet the two tasks- filter the repos and filter the good first issues.

Let me know if you have any questions!

Done!

@ArshMalik02
Copy link

Should I filter the live feed and good first issues too? Imo it's ok for the live feed to show everything, but I'm not sure if the good first issues tag is used exclusively for open source projects.

@Amyh11325 we should filter the good first issues to be only coming from repos that have ucla-opensource as one of the topics. We can leave the live feed as is. Check out this issue #156 that details the tasks we need to do to make this transition.
You can modify this PR to meet the two tasks- filter the repos and filter the good first issues.
Let me know if you have any questions!

Done!

@Amyh11325 I noticed that the projects page lists a subset of repos that are listed here (https://github.com/topics/ucla-opensource). Can we introduce a change that lists all the ucla-opensource repos and not only those owned by ACM?

@Amyh11325
Copy link
Contributor Author

Should I filter the live feed and good first issues too? Imo it's ok for the live feed to show everything, but I'm not sure if the good first issues tag is used exclusively for open source projects.

@Amyh11325 we should filter the good first issues to be only coming from repos that have ucla-opensource as one of the topics. We can leave the live feed as is. Check out this issue #156 that details the tasks we need to do to make this transition.
You can modify this PR to meet the two tasks- filter the repos and filter the good first issues.
Let me know if you have any questions!

Done!

@Amyh11325 I noticed that the projects page lists a subset of repos that are listed here (https://github.com/topics/ucla-opensource). Can we introduce a change that lists all the ucla-opensource repos and not only those owned by ACM?

Done!
Screen Shot 2024-03-04 at 2 08 24 PM

@Amyh11325
Copy link
Contributor Author

Should the good first issues page also include repos outside the uclaacm org? I believe it's limited to uclaacm right now

@ArshMalik02
Copy link

Should the good first issues page also include repos outside the uclaacm org? I believe it's limited to uclaacm right now

Yes, since we are expanding the entire project to all ucla projects

@ArshMalik02
Copy link

ArshMalik02 commented Mar 4, 2024

Should I filter the live feed and good first issues too? Imo it's ok for the live feed to show everything, but I'm not sure if the good first issues tag is used exclusively for open source projects.

@Amyh11325 we should filter the good first issues to be only coming from repos that have ucla-opensource as one of the topics. We can leave the live feed as is. Check out this issue #156 that details the tasks we need to do to make this transition.
You can modify this PR to meet the two tasks- filter the repos and filter the good first issues.
Let me know if you have any questions!

Done!

@Amyh11325 I noticed that the projects page lists a subset of repos that are listed here (https://github.com/topics/ucla-opensource). Can we introduce a change that lists all the ucla-opensource repos and not only those owned by ACM?

Done! Screen Shot 2024-03-04 at 2 08 24 PM

can we not have the default image as the acm logo for the projects that are not owned by acm? For eg, for nvim surround, we have the acm logo there even though we are not the owner for that repo.

@Amyh11325
Copy link
Contributor Author

Should I filter the live feed and good first issues too? Imo it's ok for the live feed to show everything, but I'm not sure if the good first issues tag is used exclusively for open source projects.

@Amyh11325 we should filter the good first issues to be only coming from repos that have ucla-opensource as one of the topics. We can leave the live feed as is. Check out this issue #156 that details the tasks we need to do to make this transition.
You can modify this PR to meet the two tasks- filter the repos and filter the good first issues.
Let me know if you have any questions!

Done!

@Amyh11325 I noticed that the projects page lists a subset of repos that are listed here (https://github.com/topics/ucla-opensource). Can we introduce a change that lists all the ucla-opensource repos and not only those owned by ACM?

Done! Screen Shot 2024-03-04 at 2 08 24 PM

can we not have the default image as the acm logo for the projects that are not owned by acm?

What should the image be then?

@ArshMalik02
Copy link

Should I filter the live feed and good first issues too? Imo it's ok for the live feed to show everything, but I'm not sure if the good first issues tag is used exclusively for open source projects.

@Amyh11325 we should filter the good first issues to be only coming from repos that have ucla-opensource as one of the topics. We can leave the live feed as is. Check out this issue #156 that details the tasks we need to do to make this transition.
You can modify this PR to meet the two tasks- filter the repos and filter the good first issues.
Let me know if you have any questions!

Done!

@Amyh11325 I noticed that the projects page lists a subset of repos that are listed here (https://github.com/topics/ucla-opensource). Can we introduce a change that lists all the ucla-opensource repos and not only those owned by ACM?

Done! Screen Shot 2024-03-04 at 2 08 24 PM

can we not have the default image as the acm logo for the projects that are not owned by acm?

What should the image be then?

That's a good question! We don't have an asset for it, but if you have any recs for a default image like a stock image or something, we can explore that option.

@Amyh11325
Copy link
Contributor Author

Ok I replaced it with the ucla logo and I updated the good first issues too
Screen Shot 2024-03-04 at 2 37 06 PM

@ArshMalik02
Copy link

Ok I replaced it with the ucla logo and I updated the good first issues too Screen Shot 2024-03-04 at 2 37 06 PM

great! lgtm, approving this request and merging.

Copy link

@ArshMalik02 ArshMalik02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ArshMalik02 ArshMalik02 merged commit b2a3198 into main Mar 4, 2024
6 checks passed
@ArshMalik02 ArshMalik02 deleted the filter-by-topic branch March 4, 2024 22:44
@ArshMalik02 ArshMalik02 mentioned this pull request Mar 4, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants