-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter repos in projects page by ucla-opensource tag #155
Conversation
Should I filter the live feed and good first issues too? Imo it's ok for the live feed to show everything, but I'm not sure if the good first issues tag is used exclusively for open source projects. |
@Amyh11325 we should filter the good first issues to be only coming from repos that have You can modify this PR to meet the two tasks- filter the repos and filter the good first issues. Let me know if you have any questions! |
Done! |
@Amyh11325 I noticed that the projects page lists a subset of repos that are listed here (https://github.com/topics/ucla-opensource). Can we introduce a change that lists all the ucla-opensource repos and not only those owned by ACM? |
|
Should the good first issues page also include repos outside the uclaacm org? I believe it's limited to uclaacm right now |
Yes, since we are expanding the entire project to all ucla projects |
can we not have the default image as the acm logo for the projects that are not owned by acm? For eg, for nvim surround, we have the acm logo there even though we are not the owner for that repo. |
What should the image be then? |
That's a good question! We don't have an asset for it, but if you have any recs for a default image like a stock image or something, we can explore that option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What
Before, all repos and good first issues in the uclaacm org are shown on the projects page
After, only repos in the uclaacm org with the
ucla-opensource
topic are shown. And only good first issue topics inside repos with theucla-opensource
topic are shown.Why
Not all ucla acm repos are opensource and should be displayed on the website. Some repos are public but editors are limited to committee officers.
Code Changes
Quick change, just filtered out all repos without the topic.
Testing Repos
yarn dev
and opened localhostucla-opensource
topic in the uclaacm orgOpensource Projects:
Github Search
Testing Good First Issues
yarn dev
http://localhost:3000/contribute#good-first-issues
and checked that only repos withucla-opensource
topic are shownBefore:
After: