Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: past townhall slides button changed to be conditionally rendered #751

Merged
merged 5 commits into from
Jan 29, 2025
Merged

fix: past townhall slides button changed to be conditionally rendered #751

merged 5 commits into from
Jan 29, 2025

Conversation

Kevin-D23
Copy link
Contributor

@Kevin-D23 Kevin-D23 commented Jan 28, 2025 •
edited
Loading

Overview

  • Button for Townhall slides were still being rendered, even when link does not exist

Deploy Preview: https://deploy-preview-751--jovial-pasteur-581b4a.netlify.app/town-hall

Changes

  • Checks if slide link exists before rendering

Checklist

  • Code follows the project's style guidelines.
  • Documentation has been updated where necessary.
  • All checks pass and deploy builds with no errors.

snigdha-kansal
snigdha-kansal approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@snigdha-kansal snigdha-kansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
Shaun The Sheep

@Kevin-D23 Kevin-D23 merged commit 5beb283 into main Jan 29, 2025
8 checks passed
@Kevin-D23 Kevin-D23 deleted the fix-townhall-slides branch January 29, 2025 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snigdha-kansal snigdha-kansal snigdha-kansal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kevin-D23 @snigdha-kansal