Upgrade javaparser and enhance the fail message for parse exceptions #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nimakarimipour
changed the title
msridhar
reviewed
Sep 29, 2024
Comment on lines
176
to
190
| // The original exception is not useful for the user. We should provide a more informative one | ||
| String message = e.getMessage(); | ||
| // If the message contains the stack trace, we should remove it. | ||
| int index = message.indexOf("Problem stacktrace :"); | ||
| message = index == -1 ? message : message.substring(0, index); | ||
| System.err.println( | ||
| "javaparser was not able to parse file at: " | ||
| + path | ||
| + "\n" | ||
| + message | ||
| + "\n" | ||
| + "Shutting down."); | ||
| // Exit with error code 1 to indicate failure. | ||
| System.exit(1); | ||
| return null; |
There was a problem hiding this comment.
Rather than printing and calling System.exit here, why not create a wrapper exception object with the desired message and rethrow that? It just seems like this is not the right place to decide if this is a fatal error that should exit the JVM. Plus, directly calling System.exit makes it very difficult to write a test for this scenario.
There was a problem hiding this comment.
Sure, that sounds better. 7e4dfb1
msridhar
approved these changes
Oct 2, 2024
injector/src/main/java/edu/ucr/cs/riple/injector/exceptions/ParseException.java
Outdated
Show resolved
Hide resolved
…rseException.java Co-authored-by: Manu Sridharan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the javaparser library to version
3.26.2and enhances the fail message for parse exceptions, providing more context and clarity.Before this change, a parse exception would display a message like the following, which lacks sufficient context:
With this update, the error message now includes the file path, making it easier to locate the issue:
This change involves both the library upgrade and an improvement to the error message but both are included in this single PR rather than separated due to the small scope of changes.