Fix coordinate range check for negative strands in mafNextWithPos #88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation incorrectly applied the same coordinate range check for both positive and negative strands. This caused false positives for out-of-range errors on negative strand entries, particularly when the start position was close to the source size.
Changes made:
This fix ensures proper handling of coordinates for both strands in MAF files, preventing false error reports for valid negative strand entries.
Example of a previously failing, but valid entry:
s Callithrix_geoffroyi.k119_747665 2539 15 - 2549 ----------------------------------------------TAA-A-TAAATA-A-ATA------------A
This change impacts all tools using the mafNextWithPos function, including
mafSpeciesSubset and other MAF manipulation utilities.
Tested with previously failing MAF files to confirm correct behavior.